Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicate "update pam" task #46

Merged
merged 1 commit into from
Oct 18, 2015
Merged

Conversation

fitz123
Copy link
Contributor

@fitz123 fitz123 commented Oct 18, 2015

No description provided.

@chris-rock
Copy link
Member

thanks for finding and fixing this @fitz123

chris-rock added a commit that referenced this pull request Oct 18, 2015
remove duplicate "update pam" task
@chris-rock chris-rock merged commit d47e64f into dev-sec:master Oct 18, 2015
@fitz123
Copy link
Contributor Author

fitz123 commented Oct 18, 2015

no probs! I really want to find time to review the code a little bit. This is the most dangerous-looking repo i've using) I mean huge red messages and a lot of reports about changes when there're no changes and so on.
But idea is nice, just want to make it a little bit safer, to not afraid of multiply tasks replays. Or at least make it looks more friendly =)
I'm using this at dozens installations, so at least fixing something by small pieces)
Regards, Chris!

@rndmh3ro
Copy link
Member

Thanks @fitz123!

Can you elaborate on the part "a lot of reports about changes when there're no changes"?
When I run the playbook a second time on my ubuntu box, I only see one changed task (#47).
Would you mind creating issues for these?
And I'd really like to remove these red messages, but I don't know how. If you've got any idea, let us know!

@chris-rock
Copy link
Member

@fitz123 lets work together to improve this. Please let us know, where you see ways for improvement.

rndmh3ro pushed a commit that referenced this pull request Jul 24, 2020
rndmh3ro added a commit that referenced this pull request Jul 24, 2020
unify changelog and release actions
This was referenced Dec 14, 2020
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
unify changelog and release actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants